Conversation
Callidon
left a comment
There was a problem hiding this comment.
Hi, Thank you for your contribution. You have several issues with this PR that needs to be fixed before merging it
- All tests jobs are broken because you use a rollup version that is not compatible with the range of Node version supported by the
sparql-enginepackage. - I am not very happy about introducing a bundler for an "added browser support". Since we are using the typescript compiler, aren't they any method for injecting the missing poylfills using the TS compiler instead?
- The
browser/sparqlEngine.jsfile is a non-minified bundle of the whole package, committed as a regular file. It is a big no go for me. If you wish to continue with the bundler approach, you need to remove these kind of files, and make their generation dynamic in the Github action release job.
|
Hi :)
This would be impossible with just Typescript.
If you wish, I may also add an action for building and pushing the result to a gh-pages branch, to allow a live preview on sparql-engine served by Github Pages. |
This branch provides an experimental release of sparql-engine for the browser.
The release file is stored under
browser/sparqlEngine.js. In the same folder, you will also find anexample.htmlfile, a 1:1 porting of the already existing N3 example, which proves that the library works and is usable.The release file is generated through the
rollup.jsbuilder, with a minor hack documented in therollup.config.mjsconfiguration file.I still have to port the sparql-engine test suite to the browser, I'm going to do it as soon as possible.